Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garbage Collection: Background deletion explanation is hard to understand #47956

Open
guettli opened this issue Sep 16, 2024 · 6 comments · May be fixed by #47977
Open

Garbage Collection: Background deletion explanation is hard to understand #47956

guettli opened this issue Sep 16, 2024 · 6 comments · May be fixed by #47977
Labels
language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@guettli
Copy link
Contributor

guettli commented Sep 16, 2024

Page: https://kubernetes.io/docs/concepts/architecture/garbage-collection/#background-deletion

Background cascading deletion

In background cascading deletion, the Kubernetes API server deletes the owner object immediately and the controller cleans up the dependent objects in the background. By default, Kubernetes uses background cascading deletion unless you manually use foreground deletion or choose to orphan the dependent objects.

I have problems understanding this text.

First: If I read that, then I think Finalizers seem to get ignored if you use background-deletion. But I don't think so.

Second: "... the controller cleans up the dependent objects". What is "the controller" here? If I have a custom controller for my CRDs. Is that meant with "the controller"?

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Sep 16, 2024
@steve-hardman
Copy link
Contributor

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Sep 16, 2024
@steve-hardman
Copy link
Contributor

I also agree there is room of improving the existing content in the page.

@ayushpatil2122
Copy link
Contributor

@guettli
Finalizers are not ignored during background deletion. The owner object is marked for deletion, but finalizers still execute before fully deleting it.

The controller refers to the Kubernetes controller that manages the lifecycle of resources, which could include your custom controller for CRDs. It's responsible for cleaning up dependent objects in the background.

@sftim
Copy link
Contributor

sftim commented Sep 17, 2024

/retitle Garbage Collection: Background deletion explanation is hard to understand

@k8s-ci-robot k8s-ci-robot changed the title Garbage Collection: Background deletion. Garbage Collection: Background deletion explanation is hard to understand Sep 17, 2024
@katcosgrove
Copy link
Contributor

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 18, 2024
@Nishant-k-sagar
Copy link

Nishant-k-sagar commented Sep 19, 2024

If there is still room to work on this issue, I would like to work on this. @guettli
@ayushpatil2122
Kindly /assign this to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
7 participants