Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-string locationCount and version fields #11

Open
robertoaloi opened this issue Oct 14, 2020 · 0 comments
Open

Fix non-string locationCount and version fields #11

robertoaloi opened this issue Oct 14, 2020 · 0 comments

Comments

@robertoaloi
Copy link
Contributor

Consider a repo with the following config:

hooks:
  - key: de.aeffle.stash.plugin.stash-http-get-post-receive-hook:http-get-post-receive-hook
    enabled: true
    settings:
      locationCount: 2
      # ...config for 2 post receive hooks...

This config is broken, because locationCount needs to be a string and we also need a version field for the 2nd post receive hook to work.

Now let's consider this bogus config has already been enforced by BEC, and then someone wants to fix the problem:

hooks:
  - key: de.aeffle.stash.plugin.stash-http-get-post-receive-hook:http-get-post-receive-hook
    enabled: true
    settings:
      locationCount: '2'
      version: '3'
      # ...comfig for 2 post receive hooks...

The issue is that BEC won't detect the inconsistency between the desired and actual config, and hence won't enforce the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant