Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Move Hardcoded Email Subjects to Constants Across the User Related Files #5940

Open
2 tasks done
ThisIsMani opened this issue Sep 18, 2024 · 0 comments
Open
2 tasks done
Labels
A-users Area: Users C-refactor Category: Refactor good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants S-awaiting-triage Status: New issues that have not been assessed yet

Comments

@ThisIsMani
Copy link
Contributor

ThisIsMani commented Sep 18, 2024

Feature Description

In the current implementation, email subjects are hardcoded at multiple places across the codebase when constructing email content. To improve maintainability and avoid magic strings, each unique subject should be moved to its own constant. The goal of this issue is to identify all the places where email subjects are hardcoded, create a corresponding constant for each one, and replace the hardcoded values with the newly defined constants.

Possible Implementation

  • Search the codebase for all instances where email subjects are hardcoded.
    Example:
    subject: "You have been invited to join Hyperswitch Community!",
  • For each unique subject, create a new constant in crates/router/src/consts/user.rs.
  • Refactor the code by replacing the hardcoded subjects with their respective constants.

Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

No, but I'm happy to collaborate on a PR with someone else

@ThisIsMani ThisIsMani added S-awaiting-triage Status: New issues that have not been assessed yet C-refactor Category: Refactor good first issue Good for newcomers A-users Area: Users labels Sep 18, 2024
@ThisIsMani ThisIsMani changed the title [FEATURE] Move Hardcoded Email Subjects to Constants Across the User Related Files [REFACTOR] Move Hardcoded Email Subjects to Constants Across the User Related Files Sep 18, 2024
@ThisIsMani ThisIsMani added the hacktoberfest Issues that are up for grabs for Hacktoberfest participants label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-users Area: Users C-refactor Category: Refactor good first issue Good for newcomers hacktoberfest Issues that are up for grabs for Hacktoberfest participants S-awaiting-triage Status: New issues that have not been assessed yet
Projects
None yet
Development

No branches or pull requests

1 participant