Fix for ctrl+c on examples copies the whole text, not just the selection #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeelRajodiya
requested changes
Sep 13, 2024
| @@ -31,20 +31,13 @@ export default function CodeSnippet({ | |||
| return <span className={styles.inlineCode}>{children}</span>; | |||
| } | |||
| if (children[children.length - 1] === "\n") children = children.slice(0, -1); | |||
| // remove the last \n from children | |||
There was a problem hiding this comment.
Why did we remove this comment? Please keep as it is.
| @@ -35,6 +35,7 @@ | |||
| "framer-motion": "^11.1.9", | |||
| "geist": "^1.3.0", | |||
| "gray-matter": "^4.0.3", | |||
| "my-app": "file:", | |||
There was a problem hiding this comment.
How is this change relevant?
Comment on lines
-41
to
-47
| <div | ||
| className={styles.codeSnippetContainer} | ||
| onCopy={(e) => { | ||
| e.preventDefault(); | ||
| e.clipboardData.setData("text/plain", children); | ||
| }} | ||
| > |
There was a problem hiding this comment.
Yes, it works! but have you seen the pasted code after this change? The code is not formatted correctly. It looks something like the below image
We also need to keep the code formatted as it is in the codeblock. This formatting issue is primarily from the react-syntax-highlighter library. You can look online and find out how other projects are using this library and find some solution for the issue.
|
thank you for the review. will address these. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code fix for ctrl+c on examples copies the whole text, not just the selection
Closes #53