Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Do not leak po token in videoplayback requests to clients #4841

Open
MMaster opened this issue Aug 14, 2024 · 1 comment
Open
Labels
enhancement Improvement of an existing feature

Comments

@MMaster
Copy link

MMaster commented Aug 14, 2024

po token is leaked to clients in videoplayback request URLs.
I'm not entirely sure if it can be abused, but since pot is identifiable info it may be better to not leak it to clients watching videos on invidious instance.

Describe the solution you'd like
Rewrite the URL internally to add pot without exposing it to clients eg in video_playback route.

@MMaster MMaster added the enhancement Improvement of an existing feature label Aug 14, 2024
@unixfox
Copy link
Member

unixfox commented Aug 14, 2024

It's the same issue as #2142

Ideally we would like to do something about it, but ultimately it's too cumbersome to deal with.

Especially since we support the ability to turn off "proxy" and this won't work anymore if we hide the pot= parameter because the requests are directly sent to google servers by the browser/client.

Read also the big downside for public instances by doing this: #2142 (comment). Each separate proxy program (example http3-ytproxy) would have to be adapted for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants