Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Remove inlets specific references from the provisioners #11

Open
jsiebens opened this issue Jan 12, 2021 · 3 comments
Open

Comments

@jsiebens
Copy link
Contributor

At this moment, many provisioners have some specific, hard-coded references to inlets. Like tags or firewall rules.
Referring to this repository: https://github.com/inlets/provision-cloudinit-go, removing those references and making the provisioners more generic, they can be used as a library by others.

Expected Behaviour

Most provisioners create cloud host with hard-coded inlets references, like tags.

Current Behaviour

The provisioners can be used by others without creating inlets tags.

Possible Solution

Pass the inlets references to the provisioners as arguments. I'm aware this can be a tedious task, as there are many provisioners and they all have a target cloud specific implementation.

Steps to Reproduce (for bugs)

N/A

Context

Playing around with the provisioners as a library, I've noticed that the cloud hosts are tagged with "inlets"., while I was creating other, non-inlets relared hosts.

Your Environment

  • inlets version inlets --version
    N/A
  • Docker/Kubernetes version docker version / kubectl version:
    N/A
  • Operating System and version (e.g. Linux, Windows, MacOS):
    N/A
  • Link to your project or a code example to reproduce issue:
    https://github.com/inlets/provision-cloudinit-go
@alexellis
Copy link
Member

Does this still need any action?

@jsiebens
Copy link
Contributor Author

Not in this repository, everything is moved to cloud-provision

@alexellis alexellis transferred this issue from inlets/inletsctl Jul 26, 2021
@alexellis
Copy link
Member

I've just transferred the issue 👍

Happy to take recommendations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants