Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect City Spelling: "Kiev" instead of "Kyiv" #2696

Open
maryklevetska opened this issue Jul 18, 2024 · 6 comments
Open

Incorrect City Spelling: "Kiev" instead of "Kyiv" #2696

maryklevetska opened this issue Jul 18, 2024 · 6 comments

Comments

@maryklevetska
Copy link

Describe the bug
The city name "Kiev" is used in the Day.js library, which is incorrect. The correct spelling is "Kyiv". This issue can cause confusion and is not aligned with the internationally recognized spelling.

Expected behavior
The city name should be spelled "Kyiv" instead of "Kiev" to reflect the correct and internationally recognized spelling. "Kiev" is the russian spelling, while "Kyiv" is the Ukrainian spelling. Kyiv is in Ukraine, and the correct spelling in Ukrainian is "Kyiv".

Information

  • Day.js Version: Unknown (used by maven.com)
  • OS: macOS Sonoma version 14.5
  • Browser: Google Chrome Version 126.0.6478.127
  • Time zone: GMT+03:00 (Europe/Kyiv)
    Screenshot 2024-07-18 at 19 40 34
@alexandermirzoyan
Copy link

Any idea how the timezone is implemented on that website? @maryklevetska

I have made a search on the source code of dayjs and could not find any match with a word for "Kiev"

@maryklevetska
Copy link
Author

@alexandermirzoyan thanks for your response. Honestly, I don't know how it works, but all I have is Maven.com's answer regarding the resource they use for timezone information (attached is a screenshot from our chat). I have paid attention to other sites for the correct spelling, and there are no problems there, so I believe this is not an issue on my end. Do you think I need to contact them again for more information?
Screenshot 2024-07-22 at 11 01 03

@alexandermirzoyan
Copy link

@iamkun any idea?

@alexandermirzoyan
Copy link

Seems I found root cause of the problem - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale/getTimeZones

In the global timezone standard city Kyiv is written as Kiev. And the value is used globally. So there is aCurrent IANA name table in the link attached where it has been changed to Kyiv but seems not all browsers had been updated on that. To be sure you can open the website you have provided with Firefox if it works we can be sure that the problem is from browsers.

@maryklevetska
Copy link
Author

@alexandermirzoyan so I opened it with Firefox and the spelling is still Kiev
Screenshot 2024-07-22 at 13 23 43

@alexandermirzoyan
Copy link

@maryklevetska thank you for your response.

So seems the problem is at timezone.js file while getting the timeZoneName.

What do you think @iamkun ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants