Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce use of worker maintenance toggling #8

Open
lbjay opened this issue Jul 26, 2016 · 0 comments
Open

Reduce use of worker maintenance toggling #8

lbjay opened this issue Jul 26, 2016 · 0 comments

Comments

@lbjay
Copy link
Member

lbjay commented Jul 26, 2016

Right now the scale down operation uses the worker maintenance toggle very liberally. In psuedocode it looks approx like:

IF scale down criteria is met THEN
    put all online workers in maintenance
    IF there are enough online workers to scale down THEN
        find _n_ candidates to stop based on idleness and/or billing hour usage
        IF stop candidate(s) found THEN
             issue stop command to candidate(s)
    release all non-stopped workers from maintenance state

This leads to a lot of unnecessary maintenance toggling because the majority of the time, even if the scale down criteria is met, there are additional conditions that prevent the stopping of any workers (none idle or only used a small portion of their billing hour).

A better approach would be to identify candidates to stop as soon as the scale down criteria is met. Then for each candidate, put it in maintenance, verify that it is still idle, and stop it if it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant