Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BarChart annotations feature #1223

Open
3 tasks
jaronheard opened this issue Sep 13, 2020 · 0 comments
Open
3 tasks

Implement BarChart annotations feature #1223

jaronheard opened this issue Sep 13, 2020 · 0 comments

Comments

@jaronheard
Copy link
Contributor

jaronheard commented Sep 13, 2020

Is your feature request related to a problem? Please describe.
The current annotations prop on the BarChart renders a hard coded annotation, based on whether the annotations prop is passed, but not dependent on the annotations value

Describe the solution you'd like
The BarChart should have an annotations prop that makes sense and renders annotations

Describe alternatives you've considered
The annotations prop should be removed

Additional context
Should implement the feature satisfying the following:

  • Sensible API in context of BarChart API
  • Allows for multiple annotations
  • Adds a story showing the use of the annotations prop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant