Fix misbehaviour of value_found in DBImpl::KeyMayExist. #12935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhubner
force-pushed
the
eb/key-exists-bug
branch
2 times, most recently
from
8bbe2bc
to
61bba81
Compare
alanpaxton
reviewed
Aug 28, 2024
db/db_impl/db_impl.cc
Outdated
| // If block_cache is enabled and the index block of the table didn't | ||
| // not present in block_cache, the return value will be Status::Incomplete. | ||
| // In this case, key may still exist in the table. | ||
| if(value_found != nullptr && s.IsIncomplete()) { | ||
| if (value_found != nullptr && s.IsIncomplete()) { | ||
| // falsify later if key-may-exist but can't fetch value |
There was a problem hiding this comment.
Is it feasible to make a test for this case ?
There was a problem hiding this comment.
@alanpaxton I have test in Java, do yo think I should also write test in C++?
There was a problem hiding this comment.
@rhubner I was unclear. I mean to say, can you test the case where keyMayExist but has_value is false ? I presume the functionality you have tested in Java already has C++ tests.
It is probably easier to have a C++ test for this case. My principle with the Java API is that we need to test going from Java to C++ and back. This is usually best achieved by having a Java test which basically mirrors the C++ test.
There was a problem hiding this comment.
@alanpaxton Added test.
rhubner
force-pushed
the
eb/key-exists-bug
branch
from
eed47ba
to
12373e1
Compare
rhubner
force-pushed
the
eb/key-exists-bug
branch
from
12373e1
to
ee118c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyMayExistsetvalue_foundby default to true. Then if the value is not in cache, TTLDB returnsfalsebecause it thinks the value vas found and then mark it as corrupted. False is returned even for values which are in TTLDB.Fix #12921