Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip json-encoding the HistoryEndpoint response #961

Open
Tracked by #908
carver opened this issue Oct 5, 2023 · 1 comment
Open
Tracked by #908

Skip json-encoding the HistoryEndpoint response #961

carver opened this issue Oct 5, 2023 · 1 comment
Assignees
Labels
shelf-stable Will not be closed by stale-bot

Comments

@carver
Copy link
Collaborator

carver commented Oct 5, 2023

I think these responses should just be in the native representation. Encoding them first seems like a waste, and creates ugly workarounds like in #908, where we have to decode the header back from json in order to mash it up with the block bodies and then re-encoding it.

It seems like it should be straightforward to do the json-encoding in the rpc/ crate, as needed.

It may be that after removing this encoding, we might want to fully strip out the json-encoding logic from our native types, and purely rely on the encoding logic of reth types. (Our implementation was buggy, anyway. I can't think of a good reason for us to maintain our own copy when someone else is already maintaining it.)

@carver carver self-assigned this Oct 5, 2023
@carver
Copy link
Collaborator Author

carver commented Oct 5, 2023

I haven't actually started coding this, so maybe my opinion will change when I try. If @ogenev has any thoughts before I dig into it, I'm all ears!

@github-actions github-actions bot added the stale label Apr 3, 2024
@ogenev ogenev added shelf-stable Will not be closed by stale-bot and removed stale labels Apr 8, 2024
@ethereum ethereum deleted a comment from github-actions bot Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shelf-stable Will not be closed by stale-bot
Projects
None yet
Development

No branches or pull requests

2 participants