Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace addCustomXxxFunction with single addCustomFunction #11561

Open
janedbal opened this issue Aug 2, 2024 · 0 comments
Open

Replace addCustomXxxFunction with single addCustomFunction #11561

janedbal opened this issue Aug 2, 2024 · 0 comments

Comments

@janedbal
Copy link
Contributor

janedbal commented Aug 2, 2024

I don't understand what is the addCustom*Function actually distinguishing. All those methods in Doctrine\ORM\Query\Parser do the same thing:

  • CustomFunctionsReturningStrings
  • CustomFunctionsReturningNumerics
  • CustomFunctionsReturningDatetime

Feels like it actually does nothing and thus there could be only single addCustomFunction method. Am I correct or did I miss something?

Originally asked in #11537 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@janedbal