Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt full refresh global config does not work #24500

Open
bmarcj opened this issue Sep 16, 2024 · 2 comments
Open

dbt full refresh global config does not work #24500

bmarcj opened this issue Sep 16, 2024 · 2 comments
Labels
integration: dbt Related to dagster-dbt type: bug Something isn't working

Comments

@bmarcj
Copy link

bmarcj commented Sep 16, 2024

Dagster version

1.8.7

What's the issue?

Documentation on dbt global configs is found here:

https://docs.getdbt.com/reference/global-configs/about-global-configs

This includes the fairly critical --full-refresh flag.

Dagster documentation:
https://docs.dagster.io/_apidocs/libraries/dagster-dbt#dagster_dbt.DbtCliResource.global_config_flags

Global flags are supposed to be supported by this setting.

Unfortunately, the dagster implementation places global flags at the start of the command e.g.

dbt --full-refresh build ...

This causes an error with the dbt command line (it expects this to be at the end of the invocation).

What did you expect to happen?

The flag should be in the correct place to work.

How to reproduce?

Run a dbt asset with the global config set to ["--full-refresh"]

Deployment type

None

Deployment details

No response

Additional information

No response

Message from the maintainers

Impacted by this issue? Give it a 👍! We factor engagement into prioritization.

@bmarcj bmarcj added the type: bug Something isn't working label Sep 16, 2024
@garethbrickman garethbrickman added the integration: dbt Related to dagster-dbt label Sep 16, 2024
@clairelin135
Copy link
Contributor

Thanks for reporting, I'm adding a PR to fix: #24615

@bmarcj
Copy link
Author

bmarcj commented Sep 20, 2024

Thanks @clairelin135. That's a fine fix for this issue. Are there plans to support full refresh for dbt out of the box, or is this feature integration something users are expected to handle themselves?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: dbt Related to dagster-dbt type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants