Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add basic helm template sanitize and output in CI #1191

Open
migmartri opened this issue Aug 3, 2024 · 1 comment
Open

add basic helm template sanitize and output in CI #1191

migmartri opened this issue Aug 3, 2024 · 1 comment

Comments

@migmartri
Copy link
Member

To avoid problems like this one #1189 we should add some basic CI checks for the Helm Chart rendering.

What I'd do

  • On PR, if the helm chart directory is touched
  • do helm template chainloop -n chainloop . --set development=true
  • ideally, show the diff compared to the version without the change
@migmartri
Copy link
Member Author

migmartri commented Aug 3, 2024 •
edited
Loading

cc/ @javirln

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@migmartri