Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema to match API proposed in RFC #3

Open
jkutner opened this issue Jan 6, 2021 · 1 comment
Open

Update schema to match API proposed in RFC #3

jkutner opened this issue Jan 6, 2021 · 1 comment

Comments

@jkutner
Copy link
Member

jkutner commented Jan 6, 2021

The schema and routes exposed should be updated to match buildpacks/rfcs#125

@elbandito
Copy link
Member

elbandito commented Feb 8, 2021

@jkutner I think some of the schemas are inconsistent on the RFC

These examples look correct to me:

https://registry.buildpacks.io/api/v1/search?matches=projectriff
https://registry.buildpacks.io/api/v1/buildpacks/projectriff/command-function
https://registry.buildpacks.io/api/v1/buildpacks/projectriff/command-function/1.4.1

But I think we must have been a type in the URL/links in the body. Looks like we're putting buildpacks before /api when it should come after v1/.

For example:

  "versions": {
    "1.4.1": {
      "link": "https://registry.buildpacks.io/buildpacks/api/v1/projectriff/command-function/1.4.1"
    },
    "1.3.9": {
      "link": "https://registry.buildpacks.io/buildpacks/api/v1/projectriff/command-function/1.3.9"
    }
  }

Should probably be:

  "versions": {
    "1.4.1": {
      "link": "https://registry.buildpacks.io/api/v1/buildpacks/projectriff/command-function/1.4.1"
    },
    "1.3.9": {
      "link": "https://registry.buildpacks.io/api/v1/buildpacks/projectriff/command-function/1.3.9"
    }
  }

Are there other things that are incorrect?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants