Yanked buildpacks have no warning shown on their registry page

[edmorley]

All versions of this buildpack are yanked (including the latest version):
https://registry.buildpacks.io/buildpacks/heroku/nodejs-typescript

...however, the fact that this buildpack is yanked is not mentioned on that page - meaning users will not know, and may use it thinking it's still actively maintained.

[joshwlewis]

It looks like the registry's DB still has this buildpack recorded as "yanked": false: https://cnb-registry-api-staging.herokuapp.com//api/v1/buildpacks/heroku/nodejs-typescript/0.2.3. Seems like there's still an issue with the caching process.

[edmorley]

Oh good point.

So looking now it seems yanked is not set on update:

registry-api/cmd/index-buildpacks/main.go

Lines 191 to 200 in fec9492

	UPDATE SET
	addr = $4,
	homepage = $5,
	description = $6,
	licenses = $7,
	stacks = $8,
	version_major = $9,
	version_minor = $10,
	version_patch = $11,
	updated_at = now();

I did actually check for any other missing fields when working on #117, however, I did so by checking the list of fields set in the SQL for creation vs update, and it seems the yanked field is not set explicitly even for creation, but instead is implicitly set to false via its default value:

registry-api/db/schema.rb

Line 24 in fec9492

t.boolean "yanked", default: false

[edmorley]

So I guess the yank feature has never worked properly, and none of these yanked buildpacks are actually yanked according to API:
https://github.com/buildpacks/registry-index/issues?q=is%3Aissue+yank+is%3Aclosed

[edmorley]

This also affects the latest round of yanking (of the test multi-arch 0.0.999 releases):
https://github.com/buildpacks/registry-index/issues?q=is%3Aissue+author%3Aheroku-languages-release-bot+yank