-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "Leo" button to the toolbar #1392
Comments
@minkyeongshin — can you drop a screenshot of your design mock once it's ready? That way I'll know how much real estate I have to work with, in terms of character count. |
@rmcfadden3 - sorry for the confusion: at the present time, the design "ask" is only for an icon to go in the toolbar: in the future we may implement our own notification routine, but for now, we're focusing on the functionality... thanks! |
Is this actually possible with the JAAS API? https://developer.8x8.com/jaas/docs/customize-ui-buttons links to list of button names |
Well we can brand the default icons as described at https://developer.8x8.com/jaas/docs/jaas-prefs-advanced-branding#branding-data-payload - but are we able to create a new icon or do we have to be sneaky and misuse an existing icon? |
https://github.com/jitsi/jitsi-meet/blob/a76f9d548b2cfceaf335250867b88a41667107e0/config.js#L949 You can use a data URL or any URL to an icon. |
Thanks. Please remind me: what handler triggers when a button is pressed (presumably indexed by |
Thank you! |
I see, I was looking at the wrong documentation (developer.8x8.com rather than jitsi.github.io) and there is in fact a customToolbarButtons config option. |
Ah OK the order is defined here: https://github.com/jitsi/jitsi-meet/blob/b54cec8d77fee77218378532bfac665e75289f90/react/features/toolbox/functions.web.ts#L410-L442 So the Leo icon will always be at the end of the "More Actions" menu and we can't move it without either:
Overall, probably worth just starting with it at the end of the More Actions menu. |
Just to clarify, the button should appear for |
Sorry I mislead you. I can confirm this is not currenrly possible. We'll work on making it possible. |
@saghul - Understood. Thanks for working on it. |
Fixed in #1472 |
Add a "Leo" button to the toolbar. It should appear only for premium moderators. The button has two states: "on" and "off", which reflects whether transcription is on/off. The button toggles the transcription status. Note that this should not observe/interfere with A/V recording.
When a user (other than the moderator) gets their first transcript chunk, if they are using the Brave browser, use the Jitsi notification UI to tell the user that they can use Leo to analyze the meeting.
@minkyeongshin to provide the icon for the Leo button (based on what the Jitsi API expects).
@rmcfadden3 to provide exact wording on notification.
@bcaller - note that to detect the current state of recording, the site should listen for the
recordingStatusChanged
event.The text was updated successfully, but these errors were encountered: