Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to Cell.free in tests hang #230

Open
future-highway opened this issue Jan 2, 2023 · 4 comments
Open

Call to Cell.free in tests hang #230

future-highway opened this issue Jan 2, 2023 · 4 comments
Labels
Good First Issue New to the project? Looking for something to get started with?

Comments

@future-highway
Copy link
Contributor

Right now any test (2 currently) that calls free on a Cell seems to hang. I thought this would be solved when proxying SIGTERM to the nested auraed, but that did not happen.

Note: Using auraescript to free a Cell does not result in this issue.

@future-highway future-highway added the Good First Issue New to the project? Looking for something to get started with? label Jan 2, 2023
@dmah42
Copy link
Contributor

dmah42 commented Jan 2, 2023

this suggests the test harness is intersecting the signals somehow, at a first guess.

@future-highway
Copy link
Contributor Author

future-highway commented Jan 7, 2023

Update: the tests were using a default SharedNamespaces struct which defaults to false for all namespaces. Flipping this, to share all namespaces, makes all the tests pass.

Edit: We no longer have a SharedNamespaces struct. It has been replaced with a IsolationControls struct, which also unshares namespaces and results in the same problem.

@JeroenSoeters
Copy link
Contributor

Is this still an issue? All ignored tests in auread pass for me. Which 2 tests is this issue referring to?

@future-highway
Copy link
Contributor Author

I think so. I definitely still have issues if I flip the isolation controls to true. I was also getting intermittent hangs as is (but that may have resolved itself with recent changes to the module).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue New to the project? Looking for something to get started with?
Projects
None yet
Development

No branches or pull requests

3 participants