Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building FoundationDB would fail if CMake uses Makefile #11595

Open
xis19 opened this issue Aug 22, 2024 · 3 comments
Open

Building FoundationDB would fail if CMake uses Makefile #11595

xis19 opened this issue Aug 22, 2024 · 3 comments

Comments

@xis19
Copy link
Collaborator

xis19 commented Aug 22, 2024

CMake generates problematic Makefile which not being able to create actorcompiler.exe. The error is

make[2]: *** No rule to make target 'actorcompiler.exe', needed by 'flow/ActorCollection.actor.g.cpp'.  Stop.
@spraza
Copy link
Collaborator

spraza commented Aug 23, 2024

@xis19 Curious what's your use-case for using Make vs Ninja? And do we support Make?

@xis19
Copy link
Collaborator Author

xis19 commented Aug 26, 2024

@xis19 Curious what's your use-case for using Make vs Ninja? And do we support Make?

I was trying to set up a minimal RHEL9 build environment and use the most essential build tools. Not sure if we support Make but for the same CMakeLists.txt if CMake generates problematic Makefile while reasonable build.ninja, the compiler's backend might be buggy, or the build.ninja has the same problem yet not being triggered.

@spraza
Copy link
Collaborator

spraza commented Aug 26, 2024

Got it, thanks for the context. Fwiw, README.md mentions:

Install [Ninja](https://ninja-build.org/) (optional, but recommended)

If Ninja is optional, I would take that to mean that people use Make and therefore Make should be working.

the compiler's backend might be buggy

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants