Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ppx_op: Include config.label in the label of the primary (returned) tensor, when available, and not incorporating a label from a function argument #280

Open
lukstafi opened this issue Aug 30, 2024 · 1 comment
Open

ppx_op: Include config.label in the label of the primary (returned) tensor, when available, and not incorporating a label from a function argument #280

lukstafi opened this issue Aug 30, 2024 · 1 comment
Labels
enhancement Priority below unlabeled

Comments

@lukstafi
Copy link
Collaborator

That's as informative as including it in the inline-declared tensors.
@lukstafi
Copy link
Collaborator Author

This feature might interact badly with #210 leading to labels that are too bloated. It would still make sense if there is no function (tensor) argument, but such cases would maybe be rare. So with this new consideration it's low priority.

@lukstafi lukstafi changed the title ppx_op: Include config.label in the label of the primary (returned) tensor, when available ppx_op: Include config.label in the label of the primary (returned) tensor, when available, and not incorporating a label from a function argument Aug 30, 2024
@lukstafi lukstafi added the enhancement Priority below unlabeled label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Priority below unlabeled
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukstafi