Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in subdirectory does not trigger upload of built asset during theme watch #634

Closed
colinmeinke opened this issue May 14, 2019 · 1 comment

Comments

@colinmeinke
Copy link

colinmeinke commented May 14, 2019

This is an issue with Themekit v1.0.0, reverting to v0.8.1 fixes this issue. My guess is the issue was introduced in #601.

I run my build process with Gulp. It takes the entry file at /src/app.scss and generates /assets/app.css, which is used in my theme.liquid template.

Directory structure:

- assets
  - app.css
- src
  - app.scss (build entry file)
  - components
    - helloWorld.scss (referenced by /src/app.scss)

When running theme watch I get the following behaviour:

  • ✅ a direct change to /assets/app.css successfully uploads /assets/app.css.
  • ✅ a change to the build entry file /src/app.scss triggers a build and successfully uploads /assets/app.css.
  • ❌ a change to /src/components/helloWorld.scss does trigger a build, updating /assets/app.css as expected, but /assets/app.css is not uploaded.

If I make a change to /src/components/helloWorld.scss and then theme deploy assets/app.css it does successfully upload the change, as expected.

Update: To clarify I have gulp watch running in a second terminal window which watches the /src directory for changes, and triggers a /assets/app.css build when a change is received.

@tanema
Copy link
Contributor

tanema commented May 14, 2019

This is a duplicate of #607 and an issue with Gulp and not themekit. Please see this comment specifically on how to workaround this.

@tanema tanema closed this as completed May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants