Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the notify flag does not create or update the target file #616

Closed
NikolaDonchev opened this issue Feb 28, 2019 · 5 comments
Closed

Comments

@NikolaDonchev
Copy link

NikolaDonchev commented Feb 28, 2019

Describe the bug
Trying to use the notify flag to generate the update file

To Reproduce
Steps to reproduce the behavior:

  1. run command 'theme watch -e [something] --notify=/tmp/theme.update'

Expected behavior
A file to be created that will update on a file change. Even if I manually create the file - still nothing.

Environment (please complete the following information):

  • OS: macOS 10.14.3
  • Themekit version: v1
  • Editor: VS Code
@tanema
Copy link
Contributor

tanema commented Feb 28, 2019

This may be because of your permissions on that file/folder. You can run this example for yourself

  • start theme watch --notify=notify.txt
  • in another terminal run fswatch -o notify.txt in the same directory as your theme
  • change a file in your theme.

@NikolaDonchev
Copy link
Author

Hi @tanema, this unfortunately doesn't help. The file gets created successfully but nothing gets updated. No difference even if I change the permissions of the file.

@tanema
Copy link
Contributor

tanema commented Mar 4, 2019

Did you try using fswatch like my example? fswatch I believe comes standard on OSX so you should be able to do so without installing anything. The file only gets touched, this means only timestamps are changing, is there something else that you are expecting?

Edit: Sorry I was wrong about fswatch, it is a tool I installed. You can install it for testing with brew install fswatch

@tanema
Copy link
Contributor

tanema commented Mar 5, 2019

What are you using to watch the notify file? It wouldn't happen to be gulp, would it? We have another issue open here #607 where other users have experienced problems with gulp not picking up changes because gulp no longer watched timestamps.

@NikolaDonchev
Copy link
Author

Hi @tanema many thanks for the replies! I am luckily not using gulp anymore, only webpack. I got it to work, had some permission issues. Thanks again!

@tanema tanema closed this as completed Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants