Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues when closing flows #434

Open
fredhau opened this issue Feb 10, 2018 · 0 comments
Open

Issues when closing flows #434

fredhau opened this issue Feb 10, 2018 · 0 comments

Comments

@fredhau
Copy link
Collaborator

fredhau commented Feb 10, 2018

I experience two issues when flows are closed:

  1. If the remote peer closes a connection, on_close() will be called because recv returns 0, but the socket associated with the flow is never closed.
  2. If the event loop is stopped via e.g. a signal handler, and neat_free_ctx() is called afterwards, all open sockets are closed, but on_close() is not called for the respective flows. This results in userData associated with the flows not being freed.

I am pretty sure issue 1 is a bug, but I am not sure if issue 2 is a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant