Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future: use sincos once available in oneAPI.jl #463

Open
rkierulf opened this issue Aug 19, 2024 · 0 comments
Open

Future: use sincos once available in oneAPI.jl #463

rkierulf opened this issue Aug 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@rkierulf
Copy link
Collaborator

Feature Request

Currently we are working around the lack of sincos support in oneAPI.jl. However, sincos was recently implemented in JuliaGPU/oneAPI.jl@260a4dd. Once oneAPI tags a version with this commit, we can update our compat and make the following changes:

  • In KernelFunctions.jl, use sincos to compute sin_φ and cos_φ together in the first line inside the for loop
  • In the run_spin_precession! function in BlochGPU.jl, change _cis to cis, and remove the _cis function and implementation in GPUFunctions.jl and the KomaMRICore/ext files
  • In the run_spin_precession! function in BlochSimple.jl, change the line calculating Mxy to how it was before, so that everything is inside exp
@rkierulf rkierulf added the enhancement New feature or request label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant