Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change all struct parameter types from <:Real to <:Number #363

Open
pvillacorta opened this issue Apr 5, 2024 · 2 comments
Open

Change all struct parameter types from <:Real to <:Number #363

pvillacorta opened this issue Apr 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@pvillacorta
Copy link
Collaborator

pvillacorta commented Apr 5, 2024 •
edited by cncastillo
Loading

Feature Request

By changing parameter type from <:Real to <:Number and using Unitful.jl, the use of units (e.g. Grad(1mT, 1ms)) would be possible.

image
@pvillacorta pvillacorta added the enhancement New feature or request label Apr 5, 2024
@cncastillo
Copy link
Member

cncastillo commented Apr 5, 2024 •
edited
Loading

Thanks @pvillacorta, this is being worked on. For the Sequence object, we need to change their constructors

#362 (comment)

Related to #139, #305, #362.

@pvillacorta
Copy link
Collaborator Author

Consider changing get_itp_functions (#408) to allow interpolation with units

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cncastillo @pvillacorta