Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(low priority) shouldn't body.header not scroll with the sections? #346

Open
darenr opened this issue May 3, 2018 · 1 comment
Open

Comments

@darenr
Copy link
Contributor

darenr commented May 3, 2018

The docs seems to imply that the sections are scrollable but the body.header should not. With a templates/body/header containing a search box scrolling the templates/body/sections[0]/items causes the search box also to scroll.

If this is as-designed then please just close, if this strikes you as not what's intended then I will provide a jasonbase test case from my app.

@darenr darenr changed the title shouldn't body.header not scroll with the sections? (low priority) shouldn't body.header not scroll with the sections? May 3, 2018
@gliechtenstein
Copy link
Contributor

Yes that's because that's how native search bar works on iOS. One workaround is to move this into the top header bar as you mentioned, but this will give rise to another problem, which is "where to put the title" if the search bar is placed in the top header bar by default? This would mean all apps with a search feature will not be able to have the top title label.

Android doesn't have this problem because their title is by default displayed on the left side, but on iOS I think we'll need to a solution to this problem if we want to support this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants