Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amazon-q: Add to zap stanza #185773

Merged
merged 1 commit into from
Sep 19, 2024
Merged

amazon-q: Add to zap stanza #185773

merged 1 commit into from
Sep 19, 2024

Conversation

injust
Copy link
Contributor

@injust injust commented Sep 18, 2024

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

This adds some missing zap entries (created manually).

@bevanjkay
Copy link
Member

bevanjkay commented Sep 19, 2024

Thank you for your contribution @injust

Should we be linking the q and qterm binaries using the binary stanza in the cask file?

@injust
Copy link
Contributor Author

injust commented Sep 19, 2024

Should we be linking the q and qterm binaries using the binary stanza in the cask file?

I don't think so. Amazon Q installs those by itself.

@bevanjkay bevanjkay merged commit 63a3ca9 into Homebrew:master Sep 19, 2024
8 checks passed
@injust injust deleted the patch-1 branch September 19, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants