[Sassy Scope] Inconsistency between frequency and note

[ValeraTychov]

Version

24.05

Plugin type

Native / JACK, AU, CLAP, LV2, VST2, VST3

OS

Windows

DAW / Host (if applicable)

No response

Description

Sassy Scope incorrectly calculates note from frequency.
C#6 instead of A5 (~880 Hz)

C#5 instead of A4 (~440 Hz)

E3 instead of C3 (~130.8 Hz)

https://en.wikipedia.org/wiki/Piano_key_frequencies

The root cause is wrong calculation here

Cardinal/plugins/Cardinal/src/sassy/sassy_scope.cpp

Line 510 in 7bee022

int note = (int)(12 * log(32 * POW_2_3_4TH * (freqbins[(int)(mp.x / uiScale)] / (sizef-1))) / log(2));

Most likely this worked correctly previously with a different value of sizef.

I'd suggest to exclude sizef from the expression because note index only depends to variable frequency and base note frequency.
So the final expression should be something like the following
int note = (int)(12 * log(<Multiplicative_inverse_of_C-1_frequency> * (freqbins[(int)(mp.x / uiScale)])) / log(2));