Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that @distributed_trace is for internal usage within Azure SDKs #37342

Open
lmolkova opened this issue Sep 12, 2024 · 0 comments · May be fixed by #37478
Open

Document that @distributed_trace is for internal usage within Azure SDKs #37342

lmolkova opened this issue Sep 12, 2024 · 0 comments · May be fixed by #37478
Assignees
@kashifkhan @pvaneck @xiangyan99
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)

Comments

@lmolkova
Copy link
Member

lmolkova commented Sep 12, 2024 •
edited
Loading

The decorator implements Azure SDK-specific features (e.g. suppression, support for certain sdks like opencensus), it should not be used by the end users in their applications.

We should document it as such and, if necessary, guide users to use similar generic OTel alternative

@tracer.start_as_current_span("name")
def function():
    ...

https://github.com/open-telemetry/opentelemetry-python/blob/a8aacb0c6f2f06bf19b501d98e62f7c0e667fa4c/opentelemetry-api/src/opentelemetry/trace/__init__.py#L386
@lmolkova lmolkova added Azure.Core OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific) Client This issue points to a problem in the data-plane of the library. labels Sep 12, 2024
This was referenced Sep 17, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kashifkhan kashifkhan

@pvaneck pvaneck

@xiangyan99 xiangyan99

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. OpenTelemetry OpenTelemetry instrumentation (not Monitor-specific)
Projects
None yet
Milestone
No milestone
4 participants
@kashifkhan @pvaneck @lmolkova @xiangyan99