Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

Switching to dark mode at sunrise #60

Open
owenzhao opened this issue Apr 3, 2019 · 4 comments
Open

Switching to dark mode at sunrise #60

owenzhao opened this issue Apr 3, 2019 · 4 comments
Labels
help wanted Extra attention is needed priority: normal Sure type: bug Something isn't working

Comments

@owenzhao
Copy link

owenzhao commented Apr 3, 2019

Version 1.1.4 (0)

Auto Adjust: uncheck
Scheduled: checked with Official Sunset Sunrise.

When I manually switch to bright mode in the morning, this app turns it to dark mode again when the Sun up time comes.

I think it will be the best to check if the mode is already the desired one before switching.

@ApolloZhu
Copy link
Owner

The tricky part is, what would be the desired display mode? But your case sounds more like a simpler bug to me. The app should switch to bright mode regardless of the current state in the morning.

I’ll try to reproduce this scenario and see what could be wrong. Please let me know if this happens again.

@ApolloZhu ApolloZhu changed the title Should check current state before switching mode Switching to dark mode at sunrise Apr 4, 2019
@ApolloZhu ApolloZhu added help wanted Extra attention is needed type: bug Something isn't working labels Apr 4, 2019
@ApolloZhu
Copy link
Owner

Seems to be related to #57 ?

@owenzhao
Copy link
Author

owenzhao commented Apr 4, 2019

I think the setting has already suggested what the desired mode is, as it says "Dark Mode On Between".

AgTyPU.md.png

I had read #57 before I filed this issue. I don't think it is related. He turned off the auto brightness. But it seemed to me that was the display setting of the macOS, not the setting of this app.

@ApolloZhu
Copy link
Owner

I rewrote the theme switching code a little and hope that solves the problem. Please reopen this issue if the program still switches theme to dark mode at sunrise.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed priority: normal Sure type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants