Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional openssl #70

Open
joshniemela opened this issue Jun 24, 2024 · 6 comments
Open

Optional openssl #70

joshniemela opened this issue Jun 24, 2024 · 6 comments

Comments

@joshniemela
Copy link
Contributor

OpenSSL can often be annoying to use as a build dependency and it should be possible to use the rustls package to replace openssl

@Anush008
Copy link
Owner

We don't have it as a direct dependency though.
Could you please elaborate?

@joshniemela
Copy link
Contributor Author

If your system doesn't have OpenSSL installed, cargo build will throw an error.
This most likely is happening due to hf-hub or some other dependency that downloads stuff, I was not able to find the cause whilst swiftly looking through the dependencies

@Anush008
Copy link
Owner

This would need a fix in the upstream projects then.

@joshniemela
Copy link
Contributor Author

Indeed, from my quick checks it seems it is either hf-hub or some other package which is using it for downloading data from the internet with reqwest or an analogue, these packages already support rustls so it should be possible to make some simple upstream changes.

@mcmah309
Copy link
Contributor

It is being pulled in by fastembed -> hf-hub -> native-tls -> openssl

@mcmah309
Copy link
Contributor

mcmah309 commented Jul 15, 2024

native-tls was removed here huggingface/hf-hub@9d6502f
Resultingly, the current hf-hub does not seem to have a dependency on openssl. So hopefully this issue will resolve when they release the next version.

It may be added back though huggingface/hf-hub#56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants